Jira URL

https://jira.xwiki.org/browse/XWIKI-22590

Changes

Description

• Removed the overwrite of the default value for the messageBox colors. Usually those values are equal or very close. Without a colorTheme, one set of those values was not properly initialized.

Clarifications

• This change was added initially in beaeb18#diff-4c3b8ac56f692179aec4802811ccc197ac6055484d096a0570e808f7472d3d8c
• This was squashed from the commit 6c0b9e2 on the PR branch. I failed to see that this extra definition of the background-color was 1. superfluous because already defined in the mixin 2. incorrect in some situations.
• Bootstrap natively uses @alert-<type>-bg instead of @status-<type>-bg. The alert bg is more of a background, while the status bg is more of a border color.

Screenshots & Video

The color variation is minimal, and can only be seen on the noColorTheme situation AFAIK.

Executed Tests

Manual tests. Note that I didn't find a way to clear the noTheme cache, so I had to use a fresh instance with the messages.less file updated before the first boot to get the expected results.

Running mvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker -Pdocker -Dxwiki.enforcer.skip=true -Dxwiki.test.ui.wcag=true -Dit.test=RenamePageIT#renamePageUsedInMacroContentAndParameters -Dgradle.cache.local.enabled=false -Dgradle.cache.remote.enabled=false before the changes successfully returned the WCAG violation, while after building the changes with mvn clean install -f xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources, the contrast violation was not reported anymore.

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • None, like XWIKI-21452: Macros info, success, warning and error are only distinguished by colors #2590